LLVM/project 09dfc57 — flang/lib/Optimizer/HLFIR/Transforms LowerHLFIRIntrinsics.cpp SimplifyHLFIRIntrinsics.cpp, flang/lib/Optimizer/Transforms ConstantArgumentGlobalisation.cpp StackArrays.cpp

by Jacques Pienaar via GitHub on ⎇
[mlir] Enable decoupling two kinds of greedy behavior. (#104649)

The greedy rewriter is used in many different flows and it has a lot of
convenience (work list management, debugging actions, tracing, etc). But
it combines two kinds of greedy behavior 1) how ops are matched, 2)
folding wherever it can.

These are independent forms of greedy and leads to inefficiency. E.g.,
cases where one need to create different phases in lowering and is
required to applying patterns in specific order split across different
passes. Using the driver one ends up needlessly retrying folding/having
multiple rounds of folding attempts, where one final run would have
sufficed.

Of course folks can locally avoid this behavior by just building their
own, but this is also a common requested feature that folks keep on
working around locally in suboptimal ways.

For downstream users, there should be no behavioral change. Updating
from the deprecated should just be a find and replace (e.g., `find ./
-type f -exec sed -i
's|applyPatternsAndFoldGreedily|applyPatternsGreedily|g' {} \;` variety)
as the API arguments hasn't changed between the two.
DeltaFile
+55-17mlir/include/mlir/Transforms/GreedyPatternRewriteDriver.h
+47-1mlir/test/Transforms/test-operation-folder.mlir
+21-21mlir/test/lib/Dialect/Vector/TestVectorTransforms.cpp
+12-16mlir/test/lib/Dialect/Linalg/TestLinalgElementwiseFusion.cpp
+13-13mlir/test/lib/Dialect/Linalg/TestLinalgTransforms.cpp
+10-10mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp
+8-8mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
+8-8mlir/test/lib/Dialect/Tensor/TestTensorTransforms.cpp
+11-5mlir/test/lib/Dialect/Test/TestPatterns.cpp
+4-4mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp
+4-4mlir/test/lib/Dialect/Mesh/TestOpLowering.cpp
+3-3mlir/test/lib/Transforms/TestMakeIsolatedFromAbove.cpp
+3-3mlir/lib/Conversion/VectorToSCF/VectorToSCF.cpp
+3-3mlir/lib/Dialect/Affine/Utils/Utils.cpp
+2-2mlir/test/lib/Dialect/Test/TestTraits.cpp
+2-2flang/lib/Optimizer/HLFIR/Transforms/LowerHLFIRIntrinsics.cpp
+2-2mlir/lib/Dialect/Arith/Transforms/IntRangeOptimizations.cpp
+2-2mlir/lib/Dialect/Transform/IR/TransformOps.cpp
+2-2mlir/lib/Dialect/Bufferization/Transforms/BufferDeallocationSimplification.cpp
+2-2mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp
+2-2mlir/lib/Dialect/MemRef/Transforms/ResolveShapedTypeResultDims.cpp
+2-2mlir/test/lib/Rewrite/TestPDLByteCode.cpp
+2-2mlir/lib/Dialect/Affine/Utils/LoopUtils.cpp
+2-2mlir/test/lib/Dialect/Mesh/TestReshardingSpmdization.cpp
+2-2flang/lib/Optimizer/Transforms/ConstantArgumentGlobalisation.cpp
+2-2mlir/test/lib/Dialect/Linalg/TestLinalgDecomposeOps.cpp
+2-2flang/lib/Optimizer/Transforms/StackArrays.cpp
+2-2mlir/test/lib/Dialect/GPU/TestGpuRewrite.cpp
+2-2mlir/lib/Transforms/Utils/OneToNTypeConversion.cpp
+1-2mlir/lib/Dialect/Affine/Transforms/AffineExpandIndexOps.cpp
+1-2flang/lib/Optimizer/Transforms/AlgebraicSimplification.cpp
+1-2mlir/lib/CAPI/Transforms/Rewrite.cpp
+1-2mlir/lib/Conversion/ArithToArmSME/ArithToArmSME.cpp
+1-2mlir/lib/Conversion/ArmNeon2dToIntr/ArmNeon2dToIntr.cpp
+1-2mlir/lib/Conversion/MeshToMPI/MeshToMPI.cpp
+1-2mlir/lib/Conversion/VectorToGPU/VectorToGPU.cpp
+1-2mlir/lib/Conversion/VectorToXeGPU/VectorToXeGPU.cpp
+1-2mlir/lib/Dialect/Affine/Transforms/AffineExpandIndexOpsAsAffine.cpp
+1-2mlir/lib/Dialect/ArmSME/Transforms/OuterProductFusion.cpp
+1-2mlir/lib/Dialect/ArmSVE/Transforms/LegalizeVectorStorage.cpp
+1-2mlir/lib/Dialect/GPU/Transforms/DecomposeMemRefs.cpp
+1-2mlir/lib/Dialect/Linalg/Transforms/Detensorize.cpp
+1-2mlir/lib/Dialect/Math/Transforms/UpliftToFMA.cpp
+1-2mlir/lib/Dialect/SPIRV/Transforms/CanonicalizeGLPass.cpp
+1-2mlir/lib/Dialect/SPIRV/Transforms/SPIRVWebGPUTransforms.cpp
+1-2mlir/test/lib/Dialect/Linalg/TestDataLayoutPropagation.cpp
+1-2mlir/test/lib/Dialect/Linalg/TestLinalgRankReduceContractionOps.cpp
+1-2mlir/test/lib/Dialect/Linalg/TestPadFusion.cpp
+1-1mlir/lib/Dialect/Linalg/Transforms/Loops.cpp
+1-1mlir/lib/Dialect/Linalg/Transforms/NamedOpConversions.cpp
+1-1mlir/lib/Dialect/Linalg/Transforms/Specialize.cpp
+1-1mlir/test/lib/Dialect/Tosa/TosaTestPasses.cpp
+1-1mlir/lib/Dialect/MemRef/Transforms/ExpandStridedMetadata.cpp
+1-1mlir/lib/Dialect/MemRef/Transforms/FoldMemRefAliasOps.cpp
+1-1mlir/lib/Dialect/LLVMIR/Transforms/OptimizeForNVVM.cpp
+1-1mlir/lib/Dialect/SCF/Transforms/ForToWhile.cpp
+1-1mlir/lib/Dialect/SCF/Transforms/LoopCanonicalization.cpp
+1-1mlir/lib/Dialect/SCF/Transforms/LoopSpecialization.cpp
+1-1mlir/lib/Dialect/SCF/Transforms/TileUsingInterface.cpp
+1-1flang/lib/Optimizer/Transforms/AssumedRankOpConversion.cpp
+1-1mlir/lib/Dialect/GPU/Transforms/EliminateBarriers.cpp
+1-1flang/lib/Optimizer/HLFIR/Transforms/SimplifyHLFIRIntrinsics.cpp
+1-1mlir/lib/Dialect/EmitC/Transforms/FormExpressions.cpp
+1-1mlir/lib/Dialect/Shape/Transforms/RemoveShapeConstraints.cpp
+1-1mlir/lib/Dialect/Bufferization/Transforms/EmptyTensorToAllocTensor.cpp
+1-1mlir/lib/Dialect/Tensor/Transforms/FoldTensorSubsetOps.cpp
+1-1mlir/lib/Dialect/Tosa/Transforms/TosaLayerwiseConstantFoldPass.cpp
+1-1mlir/lib/Dialect/Tosa/Transforms/TosaMakeBroadcastable.cpp
+1-1mlir/lib/Dialect/Tosa/Transforms/TosaOptionalDecompositions.cpp
+1-1mlir/lib/Dialect/Async/Transforms/AsyncParallelFor.cpp
+1-1mlir/lib/Dialect/Vector/Transforms/LowerVectorMask.cpp
+1-1mlir/lib/Dialect/Vector/Transforms/LowerVectorMultiReduction.cpp
+1-1mlir/lib/Dialect/XeGPU/Transforms/XeGPUFoldAliasOps.cpp
+1-1mlir/lib/Reducer/ReductionTreePass.cpp
+1-1mlir/lib/Transforms/Canonicalizer.cpp
+1-1mlir/lib/Dialect/Affine/Transforms/SimplifyAffineStructures.cpp
+1-1flang/lib/Optimizer/HLFIR/Transforms/InlineElementals.cpp
+1-1mlir/lib/Dialect/Affine/Transforms/AffineDataCopyGeneration.cpp
+1-1mlir/test/lib/Conversion/MathToVCIX/TestMathToVCIXConversion.cpp
+1-1mlir/test/lib/Conversion/VectorToSPIRV/TestVectorReductionToSPIRVDotProd.cpp
+1-1mlir/test/lib/Dialect/Affine/TestAffineDataCopy.cpp
+1-1mlir/test/lib/Dialect/ArmNeon/TestLowerToArmNeon.cpp
+1-1mlir/lib/Dialect/Affine/TransformOps/AffineTransformOps.cpp
+1-1mlir/test/lib/Tools/PDLL/TestPDLL.cpp
+1-1mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVMPass.cpp
+1-1mlir/lib/Conversion/VectorToArmSME/VectorToArmSMEPass.cpp
+1-1mlir/test/lib/Dialect/Linalg/TestLinalgFusionTransforms.cpp
+1-1mlir/test/lib/Transforms/TestCommutativityUtils.cpp
+1-1mlir/lib/Conversion/ShapeToStandard/ConvertShapeConstraints.cpp
+1-1flang/lib/Optimizer/HLFIR/Transforms/OptimizedBufferization.cpp
+1-1mlir/test/lib/Dialect/Math/TestAlgebraicSimplification.cpp
+1-1mlir/test/lib/Dialect/Math/TestExpandMath.cpp
+1-1mlir/test/lib/Dialect/Math/TestPolynomialApproximation.cpp
+1-1mlir/test/lib/Dialect/MemRef/TestComposeSubView.cpp
+1-1mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
+1-1mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp
+1-1mlir/test/lib/Dialect/Mesh/TestSimplifications.cpp
+1-1mlir/test/lib/Dialect/NVGPU/TestNVGPUTransforms.cpp
+1-1mlir/test/lib/Dialect/SCF/TestSCFUtils.cpp
+1-1mlir/test/lib/Dialect/SCF/TestSCFWrapInZeroTripCheck.cpp
+1-1mlir/test/lib/Dialect/SCF/TestUpliftWhileToFor.cpp
+1-1mlir/lib/Conversion/ArithToAMDGPU/ArithToAMDGPU.cpp
+1-1mlir/examples/standalone/lib/Standalone/StandalonePasses.cpp
+1-1mlir/lib/Dialect/Linalg/TransformOps/LinalgTransformOps.cpp
+1-1mlir/lib/Dialect/Linalg/Transforms/BlockPackMatmul.cpp
+1-1mlir/docs/PatternRewriter.md
+1-1mlir/lib/Dialect/Linalg/Transforms/DropUnitDims.cpp
+1-1mlir/lib/Dialect/Linalg/Transforms/ElementwiseOpFusion.cpp
+1-1mlir/lib/Dialect/Linalg/Transforms/Generalization.cpp
+1-1mlir/lib/Dialect/Linalg/Transforms/InlineScalarOperands.cpp
+313-246110 files

UnifiedSplitRaw