OPNSense/core 0d388f9src/opnsense/mvc/app/models/OPNsense/Dnsmasq Dnsmasq.php

Update src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php

Co-authored-by: Ad Schellevis <AdSchellevis at users.noreply.github.com>
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php
+1-11 files

OPNSense/core fa0d2e8src/opnsense/mvc/app/models/OPNsense/Dnsmasq Dnsmasq.php

Update src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php

Co-authored-by: Ad Schellevis <AdSchellevis at users.noreply.github.com>
DeltaFile
+1-1src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php
+1-11 files

OPNSense/core 905b990src/opnsense/scripts/filter read_log.py, src/opnsense/service/conf/actions.d actions_filter.conf

filter: replace update_params for argparse
DeltaFile
+11-9src/opnsense/scripts/filter/read_log.py
+2-2src/opnsense/service/conf/actions.d/actions_filter.conf
+13-112 files

OPNSense/core 14ed17esrc/opnsense/mvc/app/models/OPNsense/Dnsmasq Dnsmasq.php

dnsmasq: Add comment to IPv6 bracket trim
DeltaFile
+1-0src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php
+1-01 files

OPNSense/core 207bddcsrc/opnsense/mvc/app/controllers/OPNsense/TrafficShaper IndexController.php, src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/Api SettingsController.php

TrafficShaper: Implement base_bootgrid_table and base_apply_button (#8524)

DeltaFile
+13-107src/opnsense/mvc/app/views/OPNsense/TrafficShaper/index.volt
+47-0src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms/dialogPipe.xml
+32-0src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms/dialogQueue.xml
+29-0src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms/dialogRule.xml
+3-16src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/Api/SettingsController.php
+6-0src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/IndexController.php
+130-1236 files

OPNSense/core 368598e. plist

plist
DeltaFile
+2-0plist
+2-01 files

OPNSense/core f90e544src/etc/ssl/ext_sources README, src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes CertificatesField.php

System: Trust: Certificates - offer config directory (/usr/local/etc/ssl/ext_sources/) to store locations for certificates not managed by us, but practical to know about their existence.  closes https://github.com/opnsense/core/issues/8279

This is useful for services like OPNWAF and Caddy. This commit only adds the facility and changes the admin page, the widget is left unaltered.
DeltaFile
+59-0src/opnsense/scripts/system/cert_fetch_local.py
+21-0src/opnsense/mvc/app/models/OPNsense/Trust/FieldTypes/CertificatesField.php
+14-2src/opnsense/mvc/app/views/OPNsense/Trust/cert.volt
+14-0src/etc/ssl/ext_sources/README
+6-0src/opnsense/service/conf/actions.d/actions_system.conf
+114-25 files

OPNSense/core 6e8f86csrc/opnsense/mvc/app/controllers/OPNsense/TrafficShaper IndexController.php, src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/Api SettingsController.php

TrafficShaper: Implement base_bootgrid_table and base_apply_button
DeltaFile
+13-107src/opnsense/mvc/app/views/OPNsense/TrafficShaper/index.volt
+47-0src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms/dialogPipe.xml
+32-0src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms/dialogQueue.xml
+29-0src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/forms/dialogRule.xml
+3-16src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/Api/SettingsController.php
+6-0src/opnsense/mvc/app/controllers/OPNsense/TrafficShaper/IndexController.php
+130-1236 files

OPNSense/core 63b9f2esrc/etc/inc system.inc, src/www system_general.php

system: allow multiple manual DNS search domains; closes #8522

The length and input isn't bound but when writing resolv.conf
we will adhere to the requirement mentioned in the man page:

    The search list is currently limited to six domains
    with a total of 256 characters.

We simply don't always know how many the system was being provided
with from the ISP so it is what it is.
DeltaFile
+20-7src/www/system_general.php
+10-6src/etc/inc/system.inc
+30-132 files

OPNSense/core 507857fsrc/opnsense/scripts/filter/lib/alias uri.py

Firewall: Aliases - fix regression in alias table in json format (https://github.com/opnsense/core/issues/8277)

In order to support both formats, we should break with the first succesful compile().

A workaround in the current version is to omit the {.} in the path expression.

(cherry picked from commit 7ec7e1d174b5470c339e5a9653b01ea2b17a7134)
DeltaFile
+1-0src/opnsense/scripts/filter/lib/alias/uri.py
+1-01 files

OPNSense/core 30fcc7asrc/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt, src/opnsense/www/css jquery.bootgrid.css

Revert "bootgrid: resizable columns (#8496)"

This reverts commit de5dd5f5278edbae14bfa1bc76751ae360b834e0.

table-layout: auto; seems to do more harm than good, while originally
intended to improve out-of-bounds table row situations, it proves
to cause the same issue for long cell content as it now
ignores overflow:ellipsis.

(cherry picked from commit dbf37413b94997a7a9ec476ef584b01597ed1f59)
DeltaFile
+4-321src/opnsense/www/js/jquery.bootgrid.js
+1-32src/opnsense/www/css/jquery.bootgrid.css
+1-32src/opnsense/www/themes/opnsense-dark/build/css/jquery.bootgrid.css
+0-1src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+6-3864 files

OPNSense/core dbf3741src/opnsense/mvc/app/views/OPNsense/Firewall filter_rule.volt, src/opnsense/www/css jquery.bootgrid.css

Revert "bootgrid: resizable columns (#8496)"

This reverts commit de5dd5f5278edbae14bfa1bc76751ae360b834e0.

table-layout: auto; seems to do more harm than good, while originally
intended to improve out-of-bounds table row situations, it proves
to cause the same issue for long cell content as it now
ignores overflow:ellipsis.
DeltaFile
+4-321src/opnsense/www/js/jquery.bootgrid.js
+1-32src/opnsense/www/themes/opnsense-dark/build/css/jquery.bootgrid.css
+1-32src/opnsense/www/css/jquery.bootgrid.css
+0-1src/opnsense/mvc/app/views/OPNsense/Firewall/filter_rule.volt
+6-3864 files

OPNSense/core 4720675src/opnsense/mvc/app/models/OPNsense/Dnsmasq Dnsmasq.php

dnsmasq: Put IPv6 value check inline since dhcp-match and dhcp-option have been unified in master.
DeltaFile
+30-33src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php
+30-331 files

OPNSense/core ad28873src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api SettingsController.php, src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/forms dialogDHCPmatch.xml dialogDHCPoption.xml

Merge branch 'master' into kea-validate-option6
DeltaFile
+0-32src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/forms/dialogDHCPmatch.xml
+0-27src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php
+0-26src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api/SettingsController.php
+11-14src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.xml
+11-11src/opnsense/mvc/app/views/OPNsense/Dnsmasq/settings.volt
+17-1src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/forms/dialogDHCPoption.xml
+39-1116 files not shown
+55-13012 files

OPNSense/core 732a393src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api SettingsController.php, src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/forms dialogDHCPmatch.xml

dnsmasq: Unify dhcp-option and dhcp-match in the same grid (#8516)

* dnsmasq: Unify dhcp-option and dhcp-match in the same grid

Both dhcp-option and dhcp-match use almost the same fields in the form and concern the same options.
Unifying them could make sense to remove some duplicate code and potentially improving the UX.

* make plist and remove console log debug statement
DeltaFile
+0-32src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/forms/dialogDHCPmatch.xml
+0-26src/opnsense/mvc/app/controllers/OPNsense/Dnsmasq/Api/SettingsController.php
+11-14src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.xml
+3-19src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php
+11-11src/opnsense/mvc/app/views/OPNsense/Dnsmasq/settings.volt
+9-9src/opnsense/service/templates/OPNsense/Dnsmasq/dnsmasq.conf
+34-1114 files not shown
+51-11610 files

OPNSense/core 7ec7e1dsrc/opnsense/scripts/filter/lib/alias uri.py

Firewall: Aliases - fix regression in alias table in json format (https://github.com/opnsense/core/issues/8277)

In order to support both formats, we should break with the first succesful compile().

A workaround in the current version is to omit the {.} in the path expression.
DeltaFile
+1-0src/opnsense/scripts/filter/lib/alias/uri.py
+1-01 files

OPNSense/core 82742ecsrc/opnsense/mvc/app/models/OPNsense/Dnsmasq Dnsmasq.php

dnsmasq: Improve the IPv6 bracket check, also handle multiple ipv6 addresses that are comma separated, use isIpv6Address()
DeltaFile
+35-30src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php
+35-301 files

OPNSense/core 97da222src/www services_router_advertisements.php

radvd: refactor use of get_configured_carp_interface_list()
DeltaFile
+6-6src/www/services_router_advertisements.php
+6-61 files

OPNSense/core fba96d2src/opnsense/mvc/app/models/OPNsense/Dnsmasq Dnsmasq.php

dnsmasq: Implement a light validation for option6 values as they require to be wrapped inside square brackets if they contain an IPv6 address
DeltaFile
+32-0src/opnsense/mvc/app/models/OPNsense/Dnsmasq/Dnsmasq.php
+32-01 files

OPNSense/core ef1c4e0src/opnsense/mvc/app/models/OPNsense/Kea/ACL ACL.xml

kea: Fix missing ACL privileges (#8519)

DeltaFile
+18-0src/opnsense/mvc/app/models/OPNsense/Kea/ACL/ACL.xml
+18-01 files

OPNSense/core eb826d4. plist, src/opnsense/mvc/app/views/OPNsense/Dnsmasq settings.volt

make plist and remove console log debug statement
DeltaFile
+0-1plist
+0-1src/opnsense/mvc/app/views/OPNsense/Dnsmasq/settings.volt
+0-22 files

OPNSense/core c96387fsrc/opnsense/mvc/app/models/OPNsense/Kea/ACL ACL.xml

kea: Fix missing ACL privileges
DeltaFile
+18-0src/opnsense/mvc/app/models/OPNsense/Kea/ACL/ACL.xml
+18-01 files

OPNSense/core adf95bcsrc/www services_router_advertisements.php

radvd: fix description lookup for #8512
DeltaFile
+1-1src/www/services_router_advertisements.php
+1-11 files

OPNSense/core 25d629fsrc/www services_router_advertisements.php

radvd: fix list of source addresses on overlapping link-locals (#8517)

DeltaFile
+4-3src/www/services_router_advertisements.php
+4-31 files

OPNSense/core e6eecf7src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes GroupField.php

firewall: tweak

(cherry picked from commit 384af7f0194eec0722327c12d9bc2a2621266403)
(cherry picked from commit 557b793a4ed5a79918a1b0b942236138fc1c64bf)
DeltaFile
+23-25src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/GroupField.php
+23-251 files

OPNSense/core 557b793src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes GroupField.php

mvc: style
DeltaFile
+23-25src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/GroupField.php
+23-251 files

OPNSense/core 17dcdaesrc/opnsense/mvc/app/models/OPNsense/Unbound Unbound.xml

unbound: model style

(cherry picked from commit 433d8d62b3f8f2ef754c19b45bed82e937303395)
DeltaFile
+0-1src/opnsense/mvc/app/models/OPNsense/Unbound/Unbound.xml
+0-11 files

OPNSense/core ba682e4src/opnsense/mvc/app/controllers/OPNsense/Firewall FilterController.php, src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api FilterController.php

firewall: automation: correct check order

(cherry picked from commit 9c68e2eb3c447e68bf92e37c81a4fad265e02596)
(cherry picked from commit c1e601f8cb7551faaf15bc8180d4d3a05fb64416)
(cherry picked from commit 62536e40eee7a61b46dd9d4096e42bf82b39a692)
DeltaFile
+5-6src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php
+1-2src/opnsense/mvc/app/controllers/OPNsense/Firewall/FilterController.php
+0-1src/opnsense/mvc/app/controllers/OPNsense/Firewall/forms/dialogFilterRule.xml
+6-93 files

OPNSense/core 8d589ddsrc/opnsense/mvc/app/views/OPNsense/Auth user.volt, src/opnsense/mvc/app/views/layout_partials base_dialog.volt base_form.volt

mvc/view: Ensure fields stay aligned relatively to another when headers are used in forms (#8364)

(cherry picked from commit 387c3813000be8d64e58da0c82014574729545a8)
(cherry picked from commit 46999a32c3a76d21d285b1ae96fbdf2feb3d60d3)
DeltaFile
+27-7src/opnsense/mvc/app/views/layout_partials/base_dialog.volt
+20-9src/opnsense/mvc/app/views/layout_partials/base_form.volt
+0-6src/opnsense/mvc/app/views/OPNsense/Auth/user.volt
+47-223 files

OPNSense/core aae71cbsrc/opnsense/mvc/app/views/OPNsense/Core firmware.volt

firmware: "fix" the issue of user clicking check after clicking check from dashboard

We could move the check to backend() at the risk of breaking firmware upgrades on
errors.  Breaking the auto-check seems like the lesser evil.

In reality you can always go back to the status tab and re-create the issue by
clicking check for updates again after already having it clicked.  That is why the
page actually switches to the updates tab on click.  The update click is also delayed
to give the status call to fill the status tab first which immitates a normal page
render.

The issue actually appears because:

1. Backend options are detached and are dispatched, but since they run in the backround
   we don't return any feedback because we don't have it.  This then...
2. ... creates a parallel chain of trackStatus() calls which eventually reports the same
   modal.

The issue only appears when no updates are found or triggering a separate error modal.

    [7 lines not shown]
DeltaFile
+8-2src/opnsense/mvc/app/views/OPNsense/Core/firmware.volt
+8-21 files